-
Notifications
You must be signed in to change notification settings - Fork 52
docs: clarify that behavior when provided a nested sequence to asarray
is unspecified
#917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ev-br
wants to merge
1
commit into
data-apis:main
Choose a base branch
from
ev-br:asarray_nested_arrays
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2025
lucascolley
reviewed
Mar 28, 2025
Comment on lines
+93
to
+95
.. note:: | ||
If ``obj`` is a sequence with some elements being arrays, the behavior is unspecified and thus implementation-defined. Conforming | ||
implentations may perform the conversion or raise an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
.. note:: | |
If ``obj`` is a sequence with some elements being arrays, the behavior is unspecified and thus implementation-defined. Conforming | |
implentations may perform the conversion or raise an error. | |
.. note:: | |
If ``obj`` is a sequence with some elements being arrays, the behavior is unspecified and thus implementation-defined. Conforming | |
implentations may perform the conversion or raise an error. | |
To join a sequence of arrays along a new axis, see :func:`~array_api.stack`. |
asarray
is unspecified
ev-br
added a commit
to ev-br/scipy
that referenced
this pull request
Apr 10, 2025
This to be forward compatible with data-apis/array-api#917 (planned for Array API spec 2025.12)
ev-br
added a commit
to ev-br/scipy
that referenced
this pull request
Apr 10, 2025
This to be forward compatible with data-apis/array-api#917 (planned for Array API spec 2025.12)
ev-br
added a commit
to ev-br/scipy
that referenced
this pull request
Apr 10, 2025
This to be forward compatible with data-apis/array-api#917 (planned for Array API spec 2025.12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in data-apis/array-api-strict#118.
AFAICS, the behavior of
asarray([array, list])
does vary by implementation and is not explicitly mentioned in the standard. Thus add a note that it's unspecified.Due diligence:
CuPy : allows sequences of arrays, does not allows mixed sequences of arrays/scalars:
Torch: does not allow sequences of tensors
JAX : allows sequences but not scalars
Dask.array: as JAX.